Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SocketIOTestClient can handle disconnect event from server #967

Merged
merged 1 commit into from May 5, 2019
Merged

SocketIOTestClient can handle disconnect event from server #967

merged 1 commit into from May 5, 2019

Conversation

mclate
Copy link
Contributor

@mclate mclate commented May 5, 2019

This PR makes possible to test disconnect event from server. Now, if servers closes the connection, corresponding connected state is set to False in test client.

@miguelgrinberg
Copy link
Owner

Very nice. Thanks!

@miguelgrinberg miguelgrinberg merged commit 611fa68 into miguelgrinberg:master May 5, 2019
@mclate
Copy link
Contributor Author

mclate commented May 6, 2019

@miguelgrinberg Should library version be bumped somehow?

@miguelgrinberg
Copy link
Owner

Yes, I need to get a release out.

@mclate mclate deleted the test-disconnect branch May 6, 2019 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants