allow Path objects to be used as directory parameter
#319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nioncode
force-pushed
the
path
branch
2 times, most recently
from
d4d8101
to
a0c87ab
Compare
|
@miguelgrinberg could you please have a look at the Travis failures? I reverted all changes, but the build still fails for some configurations. Is this known or should we first get Travis into good shape before adding the changes back? |
|
Yeah, so it looks like some of the Flask dependencies are moving on and dropping support for older Pythons, so I'll have to follow suit. Let's say we are 3.6 and up with this. |
|
@nioncode either rebase your branch from master, or just ignore your build errors on 2.7, 3.5 and pypy, as those are not being built anymore. |
|
Sweet, thanks, now everything is green and I can start to implement this. |
nioncode
force-pushed
the
path
branch
2 times, most recently
from
bfac759
to
c4f2ddb
Compare
nioncode
changed the title
Path can be used as directory parameterPath objects to be used as directory parameter
|
@miguelgrinberg this should be ready now. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generally, I'm copying the tests for
app_custom_directoryand also run them with aPathobject. Is there a way to avoid the code duplication? For the test, we could use a parameterized test, but for the actualapp_custom_directory_path.pyfile I don't see a good way, yet.Fixes #318.