add example of how to set up with init_app method #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| from flask_migrate import Migrate | ||
|
|
||
| migrate = Migrate() |
There was a problem hiding this comment.
You'd want the db also initialized up here.
db = SQLAlchemy()
migrate = Migrate()
docs/index.rst
Outdated
|
|
||
| def create_app(): | ||
| ... | ||
| # instantiate your db |
There was a problem hiding this comment.
This should be "initialize" your db.
docs/index.rst
Outdated
| ... | ||
| migrate.init_app(app, db) | ||
| ... | ||
| # import your models |
There was a problem hiding this comment.
The models do not necessarily need to be imported here, and a lot of people prefer to not do imports inside functions, so I would remove this comment and leave it up to the developer to decide where to do the import.
|
Thanks for the addition, Kyle. Take a look at my comments and let me know what you think. |
|
Agreed on all points, will push up the edits later tonight.
|
|
Made those edits and I added a docstring for the |
|
Thanks, Kyle! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.