Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flask-Migrate uses abandoned project Flask-Script #398

Closed
jugmac00 opened this issue Mar 24, 2021 · 2 comments
Closed

Flask-Migrate uses abandoned project Flask-Script #398

jugmac00 opened this issue Mar 24, 2021 · 2 comments
Labels

Comments

@jugmac00
Copy link
Contributor

The latter is no longer maintained for years, and also issues an deprecation warning, which may break the app in future:

/home/jugmac00/Projects/Flask-Migrate/.tox/py39/lib/python3.9/site-packages/flask_script/commands.py:118: DeprecationWarning: inspect.getargspec() is deprecated since Python 3.0, use inspect.signature() or inspect.getfullargspec()
  args, varargs, keywords, defaults = inspect.getargspec(func)
../home/jugmac00/Projects/Flask-Migrate/.tox/py39/lib/python3.9/site-packages/flask_script/commands.py:118: DeprecationWarning: inspect.getargspec() is deprecated since Python 3.0, use inspect.signature() or inspect.getfullargspec()
  args, varargs, keywords, defaults = inspect.getargspec(func)

I noticed that when running the tests with unittest testrunner, as this one shows deprecation warnings, unlike python setup.py tests, also see #397

@jugmac00 jugmac00 changed the title Flask-Migrate uses abandoned project Flask-Scripts Flask-Migrate uses abandoned project Flask-Script Mar 24, 2021
@miguelgrinberg
Copy link
Owner

Flask-Script is optional, so claiming that this project "uses" it is incorrect.

@jugmac00
Copy link
Contributor Author

Right! I should have looked into setup.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants