Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency conflict when upgrading eslint-plugin-promise to 5.1.0 #579

Closed
martinburger opened this issue May 26, 2021 · 5 comments
Closed

Comments

@martinburger
Copy link

martinburger commented May 26, 2021

What version of this package are you using?

20.0.0

What operating system, Node.js, and npm version?

❯ uname -v
Darwin Kernel Version 20.4.0: Thu Apr 22 21:46:47 PDT 2021; root:xnu-7195.101.2~1/RELEASE_X86_64
❯ node --version
v16.2.0
❯ npm --version
7.13.0

What happened?

I want to upgrade eslint-plugin-promise from 4.3.1 to 5.1.0.

However, this results in unresolvable dependencies:

❯ npm install
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! Found: eslint-plugin-promise@5.1.0
npm ERR! node_modules/eslint-plugin-promise
npm ERR!   dev eslint-plugin-promise@"^5.1.0" from the root project
npm ERR!   peer eslint-plugin-promise@">=4.2.1" from eslint-config-standard-with-typescript@20.0.0
npm ERR!   node_modules/eslint-config-standard-with-typescript
npm ERR!     dev eslint-config-standard-with-typescript@"^20.0.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer eslint-plugin-promise@"^4.2.1" from eslint-config-standard@16.0.2
npm ERR! node_modules/eslint-config-standard
npm ERR!   eslint-config-standard@"^16.0.0" from eslint-config-standard-with-typescript@20.0.0
npm ERR!   node_modules/eslint-config-standard-with-typescript
npm ERR!     dev eslint-config-standard-with-typescript@"^20.0.0" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /Users/$USER/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/$USER/.npm/_logs/2021-05-26T09_36_26_360Z-debug.log

What did you expect to happen?

I would like to upgrade eslint-plugin-promise to that latest version without running into above issue.

Note, this might be related to standard/eslint-config-standard#184 and #557.

@martinburger
Copy link
Author

martinburger commented May 26, 2021

FYI: It seems that #557 has been fixed already in master.

At least, if I clone this repository I can update eslint-plugin-promise to 5.1.0 and run npm install without encountering the issue in #557.

Thus, "just" releasing a new version might fix this issue here.

@mightyiam
Copy link
Owner

Should be fixed by #602.

@lygstate
Copy link

request for release new version of eslint-config-standard-with-typescript

@martinburger
Copy link
Author

Are there any plans to release a new version to fix this issue?

@meyfa
Copy link

meyfa commented Jun 28, 2022

@martinburger A plan exists, see #840; it just seems to require some further discussion until it's implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants