Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix examples by using net.JoinHostPort #1368

Merged
merged 1 commit into from Apr 15, 2022
Merged

Fix examples by using net.JoinHostPort #1368

merged 1 commit into from Apr 15, 2022

Conversation

miekg
Copy link
Owner

@miekg miekg commented Apr 15, 2022

Small fix in the examples to properly work with v6 addresses.

Closes: #1365 #1367

Signed-off-by: Miek Gieben miek@miek.nl

Small fix in the examples to properly work with v6 addresses.

Closes: #1365 #1367

Signed-off-by: Miek Gieben <miek@miek.nl>
@miekg miekg requested a review from tmthrgd as a code owner April 15, 2022 08:09
@miekg miekg merged commit c760d3c into master Apr 15, 2022
@miekg miekg deleted the example branch April 15, 2022 08:13
aanm pushed a commit to cilium/dns that referenced this pull request Jul 29, 2022
Small fix in the examples to properly work with v6 addresses.

Closes: miekg#1365 miekg#1367

Signed-off-by: Miek Gieben <miek@miek.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IPv6 syntax error in example_test: dial udp: address <IPv6 address>:53: too many colons in address
1 participant