Only treat a *net.UnixConn of unixgram as a packet conn #1322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@jan-bar Could you please test this and see if it fixes your issue? |
miekg
approved these changes
Dec 28, 2021
Unfortunately, the server I need to connect to is of the unix type, I tried to use the unixgram type, and the server returned an error connect: protocol wrong type for socket. But if I modify the |
joliveirinha
added a commit
to joliveirinha/dns
that referenced
this pull request
Jun 8, 2022
This was broken by PR: miekg#1322
aanm
pushed a commit
to cilium/dns
that referenced
this pull request
Jul 29, 2022
* Refactor net.PacketConn checks into helper function * Only treat a *net.UnixConn of unixgram as a packet conn * Handle wrapped net.Conn types in isPacketConn * Use Error instead of Fatal where appropriate in TestIsPacketConn
aanm
pushed a commit
to cilium/dns
that referenced
this pull request
Jul 29, 2022
This was broken by PR: miekg#1322
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go supports three different types of unix connections
SOCK_STREAM(unix),SOCK_DGRAM(unixgram) andSOCK_SEQPACKET(unixpacket) all of which are*net.UnixConns. That means*net.UnixConnalways implementsnet.PacketConnregardless of the socket type, though certain methods will return errors.SOCK_DGRAMis the only one we want to treat as a packet connection and use the UDP framing for (IIUC). To do this we special case*net.UnixConns and only treatSOCK_DGRAMas anet.PacketConn.This will make it possible to properly use the DNS client over unix
SOCK_STREAMconnections (the most common type).Fixes #1321