Fix edns keepalive #1317
Merged
Fix edns keepalive #1317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current code is assuming the OPT code and length are part of the data passed to the unpacker and that it should be appenedded during packing while those fields are parsed by the caller. This change fixes the parsing and make sure a request with a keepalive won't fail.
3 tasks
|
this succeeds #1294 ? and that can be closed? |
tmthrgd
requested changes
Dec 18, 2021
tmthrgd
requested changes
Dec 20, 2021
|
Fixed review comments |
tmthrgd
approved these changes
Dec 22, 2021
|
hadn't spotted the String change, see no real reason do that (also), or is the RFC mandating something? thanks @tmthrgd |
|
Restored |
aanm
pushed a commit
to cilium/dns
that referenced
this pull request
Jul 29, 2022
* Fix un/packing of EDNS0 TCP keepalive extension The current code is assuming the OPT code and length are part of the data passed to the unpacker and that it should be appenedded during packing while those fields are parsed by the caller. This change fixes the parsing and make sure a request with a keepalive won't fail. * added tests for EDNS0_TCP_KEEPALIVE pack/unpack * mark Length as deprecated * removed named returns * restored String Co-authored-by: Olivier Poitrey <rs@rhapsodyk.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests for EDNS0_TCP_KEEPALIVE pack/unpack as requested in the original PR.
Closes #1294