Do not sign BADKEY and BADSIG TSIG error responses #1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch. The PR description should at least also show up in the commit and commit title could also just be the PR title used here. |
miekg
reviewed
Dec 3, 2021
miekg
reviewed
Dec 3, 2021
miekg
reviewed
Dec 3, 2021
…be signed. Signed-off-by: Chris O'Haver <cohaver@infoblox.com>
chrisohaver
force-pushed
the
tsig-fix-errors
branch
from
481fdaa
to
a695a65
Compare
Commits squashed with a more descriptive commit message. "Per RFC 8945 5.3.2, responses with BADKEY and BADSIG errors must not be signed." |
Signed-off-by: Chris O'Haver <cohaver@infoblox.com>
tmthrgd
reviewed
Dec 18, 2021
Signed-off-by: Chris O'Haver <cohaver@infoblox.com>
chrisohaver
force-pushed
the
tsig-fix-errors
branch
from
051787f
to
ea39b22
Compare
aanm
pushed a commit
to cilium/dns
that referenced
this pull request
Jul 29, 2022
* Per RFC 8945 5.3.2, responses with BADKEY and BADSIG errors must not be signed. Signed-off-by: Chris O'Haver <cohaver@infoblox.com> * refactor to remove else block Signed-off-by: Chris O'Haver <cohaver@infoblox.com> * skip signing only for BADKEY and BADSIG Signed-off-by: Chris O'Haver <cohaver@infoblox.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per RFC 8945 5.3.2, responses with BADKEY and BADSIG errors must not be signed.
https://datatracker.ietf.org/doc/html/rfc8945#section-5.3.2
Signed-off-by: Chris O'Haver cohaver@infoblox.com