add support for HMAC SHA224 and 384 TSIG algorithms #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1139 +/- ##
==========================================
+ Coverage 55.47% 55.51% +0.03%
==========================================
Files 41 41
Lines 10116 10124 +8
==========================================
+ Hits 5612 5620 +8
Misses 3480 3480
Partials 1024 1024
Continue to review full report at Codecov.
|
tmthrgd
approved these changes
Jul 22, 2020
aanm
pushed a commit
to cilium/dns
that referenced
this pull request
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a trivial implementation of supporting HMAC SHA224 and HMAC SHA384 for TSIG.
While these algorithms are "optional" per RFC4635, they are supported in other implementations such as BIND, so supporting them would be nice for better interoperability (and the implementation is trivial).