From a92f4255297c592f5f88a3a3d15024570112275b Mon Sep 17 00:00:00 2001
From: Rossen Stoyanchev <rstoyanchev@pivotal.io>
Date: Thu, 28 May 2020 06:51:57 +0100
Subject: [PATCH] Also use constant for custom mapping condition

See gh-25143
---
 .../web/reactive/result/method/RequestMappingInfo.java       | 4 +++-
 .../reactive/result/condition/RequestMappingInfoTests.java   | 2 ++
 .../web/servlet/mvc/method/RequestMappingInfo.java           | 5 ++++-
 .../web/servlet/mvc/method/RequestMappingInfoTests.java      | 2 ++
 4 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/spring-webflux/src/main/java/org/springframework/web/reactive/result/method/RequestMappingInfo.java b/spring-webflux/src/main/java/org/springframework/web/reactive/result/method/RequestMappingInfo.java
index 9572cfb64160..344df2f3af8d 100644
--- a/spring-webflux/src/main/java/org/springframework/web/reactive/result/method/RequestMappingInfo.java
+++ b/spring-webflux/src/main/java/org/springframework/web/reactive/result/method/RequestMappingInfo.java
@@ -67,6 +67,8 @@ public final class RequestMappingInfo implements RequestCondition<RequestMapping
 
 	private static final ProducesRequestCondition EMPTY_PRODUCES = new ProducesRequestCondition();
 
+	private static final RequestConditionHolder EMPTY_CUSTOM = new RequestConditionHolder(null);
+
 
 	@Nullable
 	private final String name;
@@ -98,7 +100,7 @@ public RequestMappingInfo(@Nullable String name, @Nullable PatternsRequestCondit
 		this.headersCondition = (headers != null ? headers : EMPTY_HEADERS);
 		this.consumesCondition = (consumes != null ? consumes : EMPTY_CONSUMES);
 		this.producesCondition = (produces != null ? produces : EMPTY_PRODUCES);
-		this.customConditionHolder = new RequestConditionHolder(custom);
+		this.customConditionHolder = (custom != null ? new RequestConditionHolder(custom) : EMPTY_CUSTOM);
 	}
 
 	/**
diff --git a/spring-webflux/src/test/java/org/springframework/web/reactive/result/condition/RequestMappingInfoTests.java b/spring-webflux/src/test/java/org/springframework/web/reactive/result/condition/RequestMappingInfoTests.java
index 528821c2f757..cb5020949b3e 100644
--- a/spring-webflux/src/test/java/org/springframework/web/reactive/result/condition/RequestMappingInfoTests.java
+++ b/spring-webflux/src/test/java/org/springframework/web/reactive/result/condition/RequestMappingInfoTests.java
@@ -69,6 +69,7 @@ public void createEmpty() {
 		assertThat(info.getHeadersCondition()).isSameAs(anotherInfo.getHeadersCondition());
 		assertThat(info.getConsumesCondition()).isSameAs(anotherInfo.getConsumesCondition());
 		assertThat(info.getProducesCondition()).isSameAs(anotherInfo.getProducesCondition());
+		assertThat(info.getCustomCondition()).isSameAs(anotherInfo.getCustomCondition());
 
 		RequestMappingInfo result = info.combine(anotherInfo);
 		assertThat(info.getPatternsCondition()).isSameAs(result.getPatternsCondition());
@@ -77,6 +78,7 @@ public void createEmpty() {
 		assertThat(info.getHeadersCondition()).isSameAs(result.getHeadersCondition());
 		assertThat(info.getConsumesCondition()).isSameAs(result.getConsumesCondition());
 		assertThat(info.getProducesCondition()).isSameAs(result.getProducesCondition());
+		assertThat(info.getCustomCondition()).isSameAs(result.getCustomCondition());
 	}
 
 	@Test
diff --git a/spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/RequestMappingInfo.java b/spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/RequestMappingInfo.java
index 67a2012d4cf2..3362cae6b645 100644
--- a/spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/RequestMappingInfo.java
+++ b/spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/RequestMappingInfo.java
@@ -69,6 +69,9 @@ public final class RequestMappingInfo implements RequestCondition<RequestMapping
 
 	private static final ProducesRequestCondition EMPTY_PRODUCES = new ProducesRequestCondition();
 
+	private static final RequestConditionHolder EMPTY_CUSTOM = new RequestConditionHolder(null);
+
+
 
 	@Nullable
 	private final String name;
@@ -100,7 +103,7 @@ public RequestMappingInfo(@Nullable String name, @Nullable PatternsRequestCondit
 		this.headersCondition = (headers != null ? headers : EMPTY_HEADERS);
 		this.consumesCondition = (consumes != null ? consumes : EMPTY_CONSUMES);
 		this.producesCondition = (produces != null ? produces : EMPTY_PRODUCES);
-		this.customConditionHolder = new RequestConditionHolder(custom);
+		this.customConditionHolder = (custom != null ? new RequestConditionHolder(custom) : EMPTY_CUSTOM);
 	}
 
 	/**
diff --git a/spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/method/RequestMappingInfoTests.java b/spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/method/RequestMappingInfoTests.java
index 2529942d7e92..2f8372312497 100644
--- a/spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/method/RequestMappingInfoTests.java
+++ b/spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/method/RequestMappingInfoTests.java
@@ -63,6 +63,7 @@ public void createEmpty() {
 		assertThat(info.getHeadersCondition()).isSameAs(anotherInfo.getHeadersCondition());
 		assertThat(info.getConsumesCondition()).isSameAs(anotherInfo.getConsumesCondition());
 		assertThat(info.getProducesCondition()).isSameAs(anotherInfo.getProducesCondition());
+		assertThat(info.getCustomCondition()).isSameAs(anotherInfo.getCustomCondition());
 
 		RequestMappingInfo result = info.combine(anotherInfo);
 		assertThat(info.getPatternsCondition()).isSameAs(result.getPatternsCondition());
@@ -71,6 +72,7 @@ public void createEmpty() {
 		assertThat(info.getHeadersCondition()).isSameAs(result.getHeadersCondition());
 		assertThat(info.getConsumesCondition()).isSameAs(result.getConsumesCondition());
 		assertThat(info.getProducesCondition()).isSameAs(result.getProducesCondition());
+		assertThat(info.getCustomCondition()).isSameAs(result.getCustomCondition());
 	}
 
 	@Test