Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please support Nokogiri >= 1.10.3 #44

Closed
JunichiIto opened this issue Apr 23, 2019 · 5 comments
Closed

Please support Nokogiri >= 1.10.3 #44

JunichiIto opened this issue Apr 23, 2019 · 5 comments

Comments

@JunichiIto
Copy link
Contributor

I want to update Nokogiri to 1.10.3 due to CVE-2019-11068, but this gem is preventing from it.

I understand you are a small team, but I would like you to fix it ASAP for the vulnerability.

JunichiIto added a commit to JunichiIto/msgraph-sdk-ruby that referenced this issue Apr 23, 2019
@JunichiIto
Copy link
Contributor Author

My pull request might solve this issue:

#45

@Younnah
Copy link

Younnah commented Feb 11, 2020

Hi @JunichiIto

When I add gem 'microsoft_graph' in the Gemfile and I run bundle install, I have this error:

Screenshot 2020-02-10 at 18 01 03

I was told that your pull request was about this problem...

Here is my stack:
ruby : ruby 2.5.1p57 (2018-03-29 revision 63029) [x86_64-darwin19]
ruby on rails : 5.2.3

I would like to use the gem as in this doc : https://docs.microsoft.com/fr-fr/outlook/rest/ruby-tutorial

Thank you for your help!


[UPDATE]
I saw that the official ruby repo for this gem is outdated, so I include the gem since this github repo directly and I up the issue about the update of the official ruby repo

@JunichiIto
Copy link
Contributor Author

@Younnah Your microsoft_graph version seems 0.1.1 but the latest version is 0.1.3 (ref.), and it might solve the problem. Could you try this?

# Gemfile
gem 'microsoft_graph', '~> 0.1.3'
bundle update microsoft_graph

@Younnah
Copy link

Younnah commented Feb 12, 2020

@JunichiIto thank you for your answer!
I tried, but I use the 1.10.4 nokogiri gem version and I have the same issue.

  In Gemfile:
    nokogiri (= 1.10.4)

    microsoft_graph (~> 0.1.3) was resolved to 0.1.3, which depends on
      nokogiri (~> 1.8.0)

Btw, add gem 'microsoft_graph', github: 'microsoftgraph/msgraph-sdk-ruby' solved my problem!

@JunichiIto
Copy link
Contributor Author

@Younnah Ah, I noticed my PR has not been released yet. (0.1.3 was released in 2017!)

Btw, add gem 'microsoft_graph', github: 'microsoftgraph/msgraph-sdk-ruby' solved my problem!

Yep, your solution seems okay 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants