Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Java 8 compatibility checks to CI #1979

Open
tsmalls93 opened this issue May 2, 2024 · 9 comments
Open

Add Java 8 compatibility checks to CI #1979

tsmalls93 opened this issue May 2, 2024 · 9 comments
Assignees
Labels
type:bug A broken experience

Comments

@tsmalls93
Copy link

Expected behavior

The SDK should work with Java 8 according to the Readme.

Actual behavior

I received the following error:

java.lang.UnsupportedClassVersionError: JVMCFRE199E bad major version 55.0 of class=jakarta/annotation/Resource, the maximum supported major version is 52.0; offset=6

Steps to reproduce the behavior

Run an app that uses javax.javaee-api 7.0 on Open Liberty that uses the SDK on version 6.6.0 or later.

@baywet
Copy link
Member

baywet commented May 2, 2024

HI @tsmalls93
Thanks for using the SDK and for reporting this.
This was caused by the upgrade to kiota dependencies 1.1.9 in #1970
Which in turns had upgraded jakarta annotations microsoft/kiota-java#1186
@Ndiritu I believe we should rollback that change in kiota libraries, and then cascade the updates. Thoughts?

@devillaccc
Copy link

I had the same issue, to resolve this I had upgraded my Java on the server to JDK11. good to have the java 8 support

@baywet
Copy link
Member

baywet commented May 2, 2024

Out of curiosity, why are you still running on Java 8 for server applications?

@tsmalls93
Copy link
Author

Out of curiosity, why are you still running on Java 8 for server applications?

We use IBM WebSphere Liberty and you can only have one Java EE runtime at a time with that product. We have hundreds of applications, so it is not practical to update them all at once. We are working towards a Cloud Native architecture with Quarkus, but we are stuck with what we have until then.

@andrueastman
Copy link
Member

HI @tsmalls93 Thanks for using the SDK and for reporting this. This was caused by the upgrade to kiota dependencies 1.1.9 in #1970 Which in turns had upgraded jakarta annotations microsoft/kiota-java#1186 @Ndiritu I believe we should rollback that change in kiota libraries, and then cascade the updates. Thoughts?

If this error can be caught at compile time, does it make sense to update the CI to probably run on Java 8 as well?

@Ndiritu
Copy link
Contributor

Ndiritu commented May 3, 2024

HI @tsmalls93 Thanks for using the SDK and for reporting this. This was caused by the upgrade to kiota dependencies 1.1.9 in #1970 Which in turns had upgraded jakarta annotations microsoft/kiota-java#1186 @Ndiritu I believe we should rollback that change in kiota libraries, and then cascade the updates. Thoughts?

Makes sense to rollback for now.
Working on adding the compile time checks to the build workflows as suggested by @andrueastman

@Ndiritu
Copy link
Contributor

Ndiritu commented May 20, 2024

@tsmalls93 this should be working from v6.9.0

@tsmalls93
Copy link
Author

Thanks @Ndiritu, it is working now.

@Ndiritu
Copy link
Contributor

Ndiritu commented May 21, 2024

Re-opening to track CI changes.

@Ndiritu Ndiritu reopened this May 21, 2024
@Ndiritu Ndiritu changed the title Java 8 compatibility broken since 6.6.0 Add Java 8 compatibility checks to CI May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug A broken experience
Projects
None yet
Development

No branches or pull requests

5 participants