Making EM fire events. #2769
Merged
Making EM fire events. #2769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 22, 2022 12:27
ghost
added
the
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
DrusTheAxe
approved these changes
Sep 9, 2022
sachintaMSFT
reviewed
Sep 9, 2022
| EnvironmentManagerInsights, | ||
| "Microsoft.Windows.System.EnvironmentManager.Insights", | ||
| (0xfbce41fa, 0xf7bc, 0x538e, 0x11, 0xf2, 0xab, 0xe1, 0xb9, 0xd2, 0xab, 0x23)); | ||
| IMPLEMENT_TELEMETRY_CLASS(EnvironmentManagerInsights, EnvironmentManagerTelemetryProvider); |
There was a problem hiding this comment.
Just happened to look at this PR.
If you are looking for telemetry, I think you want at least *MEASURES_CLASS. TELEMETRY class doesn't upload any telemetry on retail devices where as MEASURES_CLASS and CRITICAL_CLASS does. The difference between the former two is in what % of retail devices upload telemetry depending on the freshness of the in-market release.
If you are looking for just logging, you shouldn't need TELEMETRY_CLASS and TRACELOGGIN_CLASS should just do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason or another EM wasn't firing events. I changed that.
I believe the reason why was because I wasn't using the correct MACROs(?).