Switch to custom bindings for the windows::core internals
#1993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riverar
approved these changes
Aug 30, 2022
| @@ -25,6 +25,6 @@ unsafe impl<T: Interface> Sync for AgileReference<T> {} | |||
|
|
|||
| impl<T> std::fmt::Debug for AgileReference<T> { | |||
| fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { | |||
| write!(f, "AgileReference({:?})", <&IAgileReference as Into<&IUnknown>>::into(&self.0)) | |||
| write!(f, "AgileReference({:?})", &self.0 .0) | |||
There was a problem hiding this comment.
Nit: Is the space in .0 .0 intentional here?
There was a problem hiding this comment.
I noticed that too. It's rustfmt being creative. 🙄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
windows::coremodule provides various facilities in support of Windows APIs published by thewindowscrate and relies on various Windows API internally to make that happen. Up to this point, those APIs were generated by a variant of thebindgencrate but this has a few drawbacks:bindgencrateI had considered using
windows-sysinternally but that's not practical because:windows-syscrate lacks support for COM interfaceswindows-sysis versioned independently from thewindowscrateSo I ended up just taking a snapshot of the APIs I need internally. This avoids all kinds of inter-dependencies that were making it harder and harder to make improvements to the
windows::coremodule and frees me to fix a number of outstanding issues far more easily. It also greatly reduces the amount of code in thewindows::coremodule.