Produce the *_gnu import libraries more deterministically #1967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dlltool unfortunately doesn't default to a deterministic output like e.g. ar, and doesn't have a flag to enable it. Ar's MRI mode also doesn't rewrite timestamps from the libraries it merges so the best we can do as a workaround is to use objcopy, which does rewrite timestamps, but touches nothing else. Ironically, running objcopy for each intermedia library adds less overhead than once at the end.
For some reason, the import libraries currently in the repository don't match what running the tool_gnu command produces, due to the use of different prefixes. This adjusts the command to produce the same prefixes as the ones currently in the import libraries from the repository.
glandium
force-pushed
the
gnu_determinism
branch
from
6cccaeb
to
fc2b4bf
Compare
|
This PR stabilizes dlltool temporary file output (which, by default, uses the process ID in its naming scheme) for reproducible build purposes. Isn't related to our suffix issue. |
riverar
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses item 3 in #1964.