Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid generating invalid Debug traits #1473

Merged
merged 1 commit into from Jan 28, 2022
Merged

Avoid generating invalid Debug traits #1473

merged 1 commit into from Jan 28, 2022

Conversation

kennykerr
Copy link
Collaborator

@kennykerr kennykerr commented Jan 28, 2022

Structs that are (or contain) unions or are (or contain) packed layouts cannot support Debug traits. In cases where a given struct has layout differences between architectures, the bindgen crate was sometimes incorrectly producing Debug traits for the windows crate when it should not.

Fixes #1442

@kennykerr kennykerr merged commit 4bd7251 into master Jan 28, 2022
@kennykerr kennykerr deleted the debug-pack-union branch January 28, 2022 21:54
@yoshuawuyts yoshuawuyts mentioned this pull request Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: SP_CLASSINSTALL_HEADER implements Debug only on 64 bits target
1 participant