Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve core/xaml app sample ergonomics #1463

Merged
merged 2 commits into from Jan 26, 2022
Merged

Improve core/xaml app sample ergonomics #1463

merged 2 commits into from Jan 26, 2022

Conversation

riverar
Copy link
Collaborator

@riverar riverar commented Jan 26, 2022

Adds an identity check to core/xaml app samples to head off a common pitfall. Also fixes up core_app sample to behave similarly to its peer.

kennykerr
kennykerr approved these changes Jan 26, 2022
View reviewed changes
Copy link
Collaborator

@kennykerr kennykerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kennykerr kennykerr merged commit d6b88f4 into microsoft:master Jan 26, 2022
@riverar riverar deleted the rafael/xaml_app branch January 26, 2022 05:20
@yoshuawuyts yoshuawuyts mentioned this pull request Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennykerr kennykerr kennykerr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@riverar @kennykerr