Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding more Variant types #2983

Open
Guiguiprim opened this issue Apr 11, 2024 · 4 comments
Open

Adding more Variant types #2983

Guiguiprim opened this issue Apr 11, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@Guiguiprim
Copy link
Contributor

Suggestion

Hey,

Using windows-rs 0.52.0 I had my own Variant helper.
In windows-rs 0.54.0 I see that windows::core::Variant was added, which is nice.
With that change, all Windows::Win32::System::Variant::VARIANT* where removed (which completely breaks my Variant implementation).

I would be happy to migrate to windows::core::Variant but it is missing types support that I used:

  • fn null() -> Variant to construct a VT_NULL variant
  • TryFrom<&[String]> for Variant to construct VT_ARRAY_BSTR variant
  • TryFrom<&[u8]> for Variant to construct VT_ARRAY_UI1 variant

If I can, I'm going to have a try at it.

@Guiguiprim Guiguiprim added the enhancement New feature or request label Apr 11, 2024
@kennykerr
Copy link
Collaborator

Happy to review additions. I assume you mean VT_ARRAY | VT_BSTR and so on.

@hcldan
Copy link

hcldan commented May 2, 2024

We also need VT_ARRAY and VT_BSTR support.

@kennykerr
Copy link
Collaborator

VT_BSTR is already supported. It's really just VT_ARRAY that I hope to get to soon.

@hcldan
Copy link

hcldan commented May 2, 2024

Excellent!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants