Fix D3D12 sample #2084
Merged
Fix D3D12 sample #2084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennykerr
commented
Oct 3, 2022
| @@ -426,17 +426,17 @@ mod d3d12_hello_triangle { | |||
| let asset_path = exe_path.parent().unwrap(); | |||
| let shaders_hlsl_path = asset_path.join("shaders.hlsl"); | |||
| let shaders_hlsl = shaders_hlsl_path.to_str().unwrap(); | |||
| let shaders_hlsl = PCWSTR::from(&shaders_hlsl.into()); | |||
| let shaders_hlsl: HSTRING = shaders_hlsl.into(); | |||
There was a problem hiding this comment.
A temporary HSTRING was being created and then used in the subsequent calls to D3DCompileFromFile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the D3D sample mentioned here: #2082
The issue was detected using App Verifier and stems from an unsafe
Fromimplementation, which I will fix separately as it is rather involved.