Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make BSTR a core string type #2006

Merged
merged 1 commit into from Sep 6, 2022
Merged

Make BSTR a core string type #2006

merged 1 commit into from Sep 6, 2022

Conversation

kennykerr
Copy link
Collaborator

Following #1995, BSTR remained as the sole replacement type. While I'd rather avoid the hand-rolled implementation, it is such an important type in support of so many APIs that I chose instead to elevate it to a core type. This means it sits alongside HSTRING, PCWSTR, and friends.

Making it a core type also means this cleans up a few issues with convertibility and generally simplifies the implementation. We can now also more easily make it more consistent with the implementation of the other core string types.

@kennykerr kennykerr merged commit e4b778c into master Sep 6, 2022
@kennykerr kennykerr deleted the bstr branch September 6, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant