Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure string-like integer constants work in Rust #2001

Closed
kennykerr opened this issue Sep 2, 2022 · 0 comments · Fixed by #2007
Closed

Ensure string-like integer constants work in Rust #2001

kennykerr opened this issue Sep 2, 2022 · 0 comments · Fixed by #2007
Labels
bug Something isn't working

Comments

@kennykerr
Copy link
Collaborator

I'm not sure this is a metadata bug - the metadata represents this as follows:

public const PWSTR TD_WARNING_ICON = -1;

This is completely invalid but also a fairly accurate representation of what the Windows SDK declares. It may be up to the languages to coerce this properly.

Originally posted by @kennykerr in microsoft/win32metadata#1029 (comment)
@kennykerr kennykerr changed the title Ensure string-line integer constants work in Rust Ensure string-like integer constants work in Rust Sep 2, 2022
@kennykerr kennykerr added the bug Something isn't working label Sep 2, 2022
@kennykerr kennykerr mentioned this issue Sep 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds a workaround and test for MAKEINTRESOURCE style constants microsoft/windows-rs
1 participant
@kennykerr