Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test (cross-compilation) actions fail on this repository #1969

Closed
glandium opened this issue Aug 17, 2022 · 10 comments
Closed

Test (cross-compilation) actions fail on this repository #1969

glandium opened this issue Aug 17, 2022 · 10 comments
Labels
bug Something isn't working

Comments

@glandium
Copy link
Contributor

The error message is:

actions/cache@v3 is not allowed to be used in microsoft/windows-rs. Actions in this workflow must be: within a repository that belongs to your Enterprise account or matching the following: actions/checkout@v2.

@riverar
Copy link
Collaborator

riverar commented Aug 18, 2022

Where are you seeing this? Can you link to the particular test run? I don't see any failures in recent commits.

@glandium
Copy link
Contributor Author

https://github.com/microsoft/windows-rs/actions

@riverar
Copy link
Collaborator

riverar commented Aug 18, 2022

I walked right into that one, thanks.

@kennykerr kennykerr added the bug Something isn't working label Aug 22, 2022
@kennykerr
Copy link
Collaborator

Need to figure out why its not failing the CI validation for PRs - and then we should be able to add the necessary action.

@kennykerr
Copy link
Collaborator

kennykerr commented Aug 22, 2022

I allowed that cache action but it still seems to fail:

https://github.com/microsoft/windows-rs/actions/runs/2873464088

Might need to revert #1883 until we can figure this out. @mati865

@mati865
Copy link
Contributor

mati865 commented Aug 22, 2022

Oh, that's unfortunate but probably there is no other choice.
It'd be nice if #1961 could be reconsidered instead before next release.

@riverar
Copy link
Collaborator

riverar commented Aug 22, 2022

Last build seemed to pass https://github.com/microsoft/windows-rs/actions/runs/2905093873, looks okay now.

@kennykerr
Copy link
Collaborator

The build passed but it still skipped the cross compilation workflow.

@kennykerr
Copy link
Collaborator

OK, I was looking at an older build that should also have succeeded but at least the latest build seems green. 👍

@kennykerr
Copy link
Collaborator

So, I'll close this now - the fix was to enable the cache action (which I did) and the CI build finally seems to have caught up to that fact. 😜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants