Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer &T to *const T for Win32 input parameters that aren't optional #1441

Closed
kennykerr opened this issue Jan 20, 2022 · 2 comments · Fixed by #1939
Closed

Prefer &T to *const T for Win32 input parameters that aren't optional #1441

kennykerr opened this issue Jan 20, 2022 · 2 comments · Fixed by #1939
Labels
enhancement New feature or request

Comments

@kennykerr
Copy link
Collaborator

For example, the CoCreateInstance function's first parameter should be of type &GUID rather than *const GUID. Callers aren't much affected by this, but implementations are bit more tedious.
@kennykerr kennykerr added the enhancement New feature or request label Jan 20, 2022
@GamePad64
Copy link
Contributor

Also, prefer Option<&T> for optional params

@kennykerr kennykerr mentioned this issue Jul 22, 2022
Merged
@kennykerr
Copy link
Collaborator Author

@GamePad64 - as you wish! 😜 #1939

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prefer &T to *const T for Win32 input parameters microsoft/windows-rs
2 participants
@GamePad64 @kennykerr