PSAPI_VERSION support

[ldm0]

Suggestion

For win32 api like GetModuleInformation, GetPerformanceInfo, there is a PSAPI_VERSION flag to conveniently redirecting them to Kernel32.dll. But there is no such equivalent in windows crate, which makes it hard for downstream users to remove Psapi.dll's usage without forking every dependency. Normally crates won't call kernel32 apis directly(e.g. K32GetModuleInformation) for old Windows Version support(or the authors are not aware of that). It would be awesome to have a feature flag or cfg for kernel32 api redirection just like what PSAPI_VERSION does.

[kennykerr]

I believe this was to support versions of Windows older than Windows 7, so these could safely be replaced with the kernel32 versions in metadata. Will transfer for consideration.

[riverar]

Do we need to do anything here? windows and win32metadata contain both variants.

[DllImport("KERNEL32.dll", ExactSpelling = true, PreserveSig = false)]
[Documentation("https://learn.microsoft.com/windows/win32/api/psapi/nf-psapi-getmoduleinformation")]
public unsafe static extern BOOL K32GetModuleInformation([In] HANDLE hProcess, [In] HMODULE hModule, [Out] MODULEINFO* lpmodinfo, [In] uint cb);


[DllImport("PSAPI.dll", ExactSpelling = true, PreserveSig = false, SetLastError = true)]
[SupportedOSPlatform("windows5.1.2600")]
[Documentation("https://learn.microsoft.com/windows/win32/api/psapi/nf-psapi-getmoduleinformation")]
public unsafe static extern BOOL GetModuleInformation([In] HANDLE hProcess, [In] HMODULE hModule, [Out] MODULEINFO* lpmodinfo, [In] uint cb);

https://microsoft.github.io/windows-docs-rs/doc/windows/Win32/System/ProcessStatus/fn.K32GetModuleInformation.html
https://microsoft.github.io/windows-docs-rs/doc/windows/Win32/System/ProcessStatus/fn.GetModuleInformation.html

[kennykerr]

I don't have a strong opinion. One option would be to update the metadata for GetModuleInformation to point to kernel32 and use the K32GetModuleInformation entry point.

[ldm0]

One option would be to update the metadata for GetModuleInformation to point to kernel32 and use the K32GetModuleInformation entry point.

Worth noting that this change would make apps rely on win32metadata unusable on Windows XP & WIndows Vista. Since K32GetModuleInformation couldn't be found in kernel32.dll on such platofrms.

Providing a features flag for such direction might be better in terms of compatibility.

[ldm0]

BTW, it's vague that whether win32metadata supports WIndows XP / Windows Vista / Windows Server 2003. I tried but couldn't find a list of supported OSes. :-(

[mikebattista]

We exposed both variants in #920. A feature flag in the projection seems reasonable. Do you have everything you need in the metadata to do that?