Metadata needs to report calling convention correctly

[kennykerr]

Examples of discrepancies where there are no numbers in the .lib in the SDK

Those are likely because those functions aren't stdcall at all - many are likely cdecl. It would be most helpful if those are reported to the win32metadata repo since the metadata would need to indicate the calling convention before the Rust project can do anything about it.

As of now, we just assume all functions are stdcall since the metadata doesn't appear to set the CallingConvention field.

Originally posted by @kennykerr in microsoft/windows-rs#1985 (comment)

[kennykerr]

Examples include functions like DtcGetTransactionManagerExW and LdapGetLastError that are cdecl rather than stdcall. Currently the metadata doesn't appear to capture this information.

[kennykerr]

I checked the latest CI build and it doesn't seem to capture anything to do with calling convention - still reports stdcall/winapi. Was hoping the ClangSharp update would have automagically fixed this. 😜

[sotteson1]

I checked the latest CI build and it doesn't seem to capture anything to do with calling convention - still reports stdcall/winapi. Was hoping the ClangSharp update would have automagically fixed this. 😜

I just figured out I was feeding ClangSharp something that was forcing everything to be winapi. Now I'm properly seeing cdecl so I can add it to the metadata. One side effect is now methods/delegates previously reported as winapi are stdcall. If I see a stdcall should I report them as winapi, or use stdcall?

[sotteson1]

I'm going to leave stdcall functions as winapi to reduce the noise.

[elachlan]

Related: #1053

[kennykerr]

I'm going to leave stdcall functions as winapi to reduce the noise.

I believe winapi implies stdcall.

[sotteson1]

I'm going to leave stdcall functions as winapi to reduce the noise.

I believe winapi implies stdcall.

Right. It's weird the enum has both winapi and stdcall.

[kennykerr]

Here are the options in ECMA335:

I suspect winapi maps to "CallConvPlatformapi" above and basically means the default calling convention for the platform, which is stdcall for Windows.