Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft (R) Test Execution CLI, Copyright (C) Microsoft Corporation. All rights reserved. #4869

Closed
tmds opened this issue Jan 31, 2024 · 6 comments · Fixed by #5013
Closed
Assignees

Comments

@tmds
Copy link
Contributor

tmds commented Jan 31, 2024

On a source-build SDK, the vstest.console.dll (which comes as part of the distro SDK) includes these lines when you run dotnet test:

Microsoft (R) Test Execution Command Line Tool Version 17.8.0 (x64)
Copyright (c) Microsoft Corporation.  All rights reserved.

For MSBuild, we removed the Microsoft trademark/copyright bits in dotnet/msbuild#7672 and changed

Microsoft (R) Build Engine version 17.0.0+c9eb9dd64 for .NET
Copyright (C) Microsoft Corporation. All rights reserved.

into:

MSBuild version 17.8.3+195e7f5a3 for .NET

Can we make a similar change to the vstest cli?

cc @richlander @baronfel @omajid

@nohwnd
Copy link
Member

nohwnd commented Jan 31, 2024

Sure, we can do it if @richlander says it is okay. I don't have any details about what needed to be discussed or approved for this to happen in MSBuild.

I searched grep.app and we will most likely break dotnet/sdk, and few other people testing our output, but that happens every time we touch our output.

https://github.com/dotnet/sdk/blob/main/test/dotnet-test.Tests/GivenDotnetTestBuildsAndRunsTestfromCsproj.cs

Will check the naming with our team: VSTest version 17.8.0 (x64)

@tmds
Copy link
Contributor Author

tmds commented Feb 7, 2024

Sure, we can do it if @richlander says it is okay.

@richlander can you take a look?

@tmds
Copy link
Contributor Author

tmds commented Feb 20, 2024

@richlander, friendly reminder.

@richlander
Copy link
Member

Wow. This one skipped by me. Please accept my apologies!

LGTM

@MichaelSimons
Copy link
Member

Any progress on a fix for this?

@nohwnd nohwnd mentioned this issue May 2, 2024
@nohwnd
Copy link
Member

nohwnd commented May 2, 2024

Thanks for the reminder, implemented it in the linked PR, will be released in 17.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants