Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staircase in logger seems not to be properly fixed #4802

Closed
0xced opened this issue Dec 30, 2023 · 2 comments
Closed

Staircase in logger seems not to be properly fixed #4802

0xced opened this issue Dec 30, 2023 · 2 comments

Comments

@0xced
Copy link

0xced commented Dec 30, 2023

I see that commit 2850ac5 from pull request #4756 is part of the v17.9.0-preview-23577-04 tag, yet even after upgrading the Microsoft.NET.Test.Sdk package to version 17.9.0-preview-23577-04 I'm still seeing the staircase issue. 馃

Reproduction steps are the same as in the original bug report (#4754) with the following command between step 2 and 3:

dotnet add tests/Serilog.Formatting.Log4Net.Tests.csproj package Microsoft.NET.Test.Sdk --version 17.9.0-preview-23577-04
@nohwnd
Copy link
Member

nohwnd commented Jan 3, 2024

The loggers don't come with the test.sdk package, the fix is propagated with vstest.console update, meaning you need to get it by upgrading your dotnet sdk / Visual Studio / TestPlatform package.

It will come with 8.0.2xx sdk: https://github.com/dotnet/sdk/blob/release/8.0.2xx/eng/Versions.props

@0xced
Copy link
Author

0xced commented May 4, 2024

I'm not sure in what exact version of the SDK this was fixed but I confirm that the staircases are gone with the dotnet SDK 8.0.204.

@0xced 0xced closed this as completed May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants