Re-enable arm64 ngen #3931
Re-enable arm64 ngen #3931
Conversation
|
@ankitvarmait I'm re-enabling arm64 ngen for test host using the preview, now manifest looks good for arm64 modules: @davkean pls let us know if you see something strange inside logs. |
| <VsixSourceItem Update="$(VsixInputFileLocation)\testhost.net47.arm64.exe" Ngen="true" NgenArchitecture="Arm64" NgenPriority="2" NgenApplication="$(ExtensionInstallationRelativeToVS)\testhost.net47.arm64.exe" /> | ||
| <VsixSourceItem Update="$(VsixInputFileLocation)\testhost.net471.arm64.exe" Ngen="true" NgenArchitecture="Arm64" NgenPriority="2" NgenApplication="$(ExtensionInstallationRelativeToVS)\testhost.net471.arm64.exe" /> | ||
| <VsixSourceItem Update="$(VsixInputFileLocation)\testhost.net472.arm64.exe" Ngen="true" NgenArchitecture="Arm64" NgenPriority="2" NgenApplication="$(ExtensionInstallationRelativeToVS)\testhost.net472.arm64.exe" /> | ||
| <VsixSourceItem Update="$(VsixInputFileLocation)\testhost.net48.arm64.exe" Ngen="true" NgenArchitecture="Arm64" NgenPriority="2" NgenApplication="$(ExtensionInstallationRelativeToVS)\testhost.net48.arm64.exe" /> |
There was a problem hiding this comment.
As a matter of interest why do you have architecture + target framework versions of your test host?
I would consider targeting the lowest version and then setting the https://docs.microsoft.com/en-us/dotnet/api/system.appdomainsetup.targetframeworkname?view=net-6.0 property when setting up the AppDomain to the user's target to enable quirks for those tests.
There was a problem hiding this comment.
I suppose historical reason(on how the host is located today) but maybe @nohwnd has got better reason.
There was a problem hiding this comment.
Reason is that I did not know you can do it this way when I added the additional testhosts, and no-one suggested it before we do it this way.
This reverts commit e0ae648.
Revert "Re-enable arm64 ngen
This reverts commit 33122a2.
This reverts commit 33122a2.
Re-enable arm64 ngen