Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not remove packages folder in ci #3556

Merged
merged 2 commits into from Apr 8, 2022

Conversation

Haplois
Copy link
Contributor

@Haplois Haplois commented Apr 8, 2022

No description provided.

@nohwnd
Copy link
Member

nohwnd commented Apr 8, 2022

You are reverting to what I did recently. It is okay if you keep the packages unzipped always, not only in ci build. It was useful for me to have them unzipped after build, because then I can easily look into the package and pick and choose dlls from there.

The only thing I would like to ensure, if this is for signing checks, is that if the folder is deleted then the signing check will fail. Instead of passing.

@Haplois
Copy link
Contributor Author

Haplois commented Apr 8, 2022

@nohwnd
The only thing I would like to ensure, if this is for signing checks, is that if the folder is deleted then the signing check will fail. Instead of passing.

No, we restore source-build packages there which was built by another pipeline. This removes those packages and manifests. In CI, this folder is already clean and it gets cleared after pipeline is done. So I just disabled this in CI.

@nohwnd
Copy link
Member

nohwnd commented Apr 8, 2022

Please comment that in the code, that is not obvious.

@Haplois Haplois merged commit 717d0cf into rel/17.2 Apr 8, 2022
@Haplois Haplois deleted the dev/haplois/do-not-clear-pacakges/17.2 branch April 8, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants