[16.8] Fix collect dump always #2641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvpoienaru
approved these changes
Nov 18, 2020
src/Microsoft.TestPlatform.Extensions.BlameDataCollector/BlameCollector.cs
Show resolved
Hide resolved
Sanan07
approved these changes
Nov 18, 2020
This was referenced Nov 18, 2020
|
Hello @nohwnd! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
mburumaxwell
pushed a commit
to faluapp/falu-dotnet
that referenced
this pull request
Jun 12, 2021
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.7.1 to 16.8.3. #Release notes *Sourced from [Microsoft.NET.Test.Sdk's releases](https://github.com/microsoft/vstest/releases).* > ## v16.8.3 > See the release notes [here](https://github.com/microsoft/vstest-docs/blob/master/docs/releases.md#1683). > > ## v16.8.0 > See the release notes [here](https://github.com/microsoft/vstest-docs/blob/master/docs/releases.md#1680). > > ## v16.8.0-preview-20200921-01 > See the release notes [here](https://github.com/microsoft/vstest-docs/blob/master/docs/releases.md#1680-preview-20200921-01). > > ## v16.8.0-preview-20200812-03 > See the release notes [here](https://github.com/microsoft/vstest-docs/blob/master/docs/releases.md#1680-preview-20200812-03). > > ## v16.8.0-preview-20200806-02 > See the release notes [here](https://github.com/microsoft/vstest-docs/blob/master/docs/releases.md#1680-preview-20200806-02). #Commits - [`212656d`](microsoft/vstest@212656d) Set TestPlatform version as v16.8.3 ([#2662](microsoft/vstest#2662)) - [`238a218`](microsoft/vstest@238a218) Fixed PackageReferences on ObjectModel nupkg ([#2660](microsoft/vstest#2660)) - [`6e11010`](microsoft/vstest@6e11010) [16.8] Fix collect dump always ([#2641](microsoft/vstest#2641)) - [`b074e2c`](microsoft/vstest@b074e2c) Assembly load fixes ([#2644](microsoft/vstest#2644)) - [`d6875ce`](microsoft/vstest@d6875ce) Cherry-picked signing fixes from `master` ([#2619](microsoft/vstest#2619)) - [`b195e25`](microsoft/vstest@b195e25) Signing instructions for Newtonsoft.Json.dll added ([#2601](microsoft/vstest#2601)) ([#2603](microsoft/vstest#2603)) - [`0b1e2e5`](microsoft/vstest@0b1e2e5) Fix the initial assets location of VSTest assets ([#2589](microsoft/vstest#2589)) - [`2e615ad`](microsoft/vstest@2e615ad) Generate release notes in pipeline - [`2418d9e`](microsoft/vstest@2418d9e) Forward merge fixes from master to rc2 ([#2581](microsoft/vstest#2581)) - [`70a599d`](microsoft/vstest@70a599d) Fix blame parameter, warning, and add all testhosts to be ngend ([#2579](microsoft/vstest#2579)) - Additional commits viewable in [compare view](http...
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix how we collect dumps when CollectAlways is not specified. In previous versions procdump collected dump always, but because we controlled what files exactly will be uploaded we just skipped the dump when collect always was not specified. Now we no longer know which dumps will be collected, so we need to set procdump parameters correctly.
Also skip warning about sequence file when we don't collect hang dump. And prefer agent temp over normal temp, to make running on azdo contained in the agent folder.
Update branding to 16.8.1.
Related issue
Fix dotnet/sdk#14578