Multi Target Trx Issue : LogFilePrefix Parameter Added #2140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singhsarab
reviewed
Aug 27, 2019
src/Microsoft.TestPlatform.Common/Utilities/RunSettingsUtilities.cs
Outdated
Show resolved
Hide resolved
singhsarab
reviewed
Aug 27, 2019
| @@ -443,14 +444,27 @@ private void DeriveTrxFilePath() | |||
| { | |||
| if (this.parametersDictionary != null) | |||
| { | |||
| var isLogFileNameParameterExists = this.parametersDictionary.TryGetValue(TrxLoggerConstants.LogFileNameKey, out string logFileNameValue); | |||
| if (isLogFileNameParameterExists && !string.IsNullOrWhiteSpace(logFileNameValue)) | |||
| var isLogFilePrefixParameterExists = this.parametersDictionary.TryGetValue(TrxLoggerConstants.LogFilePrefixKey, out string logFilePrefixValue); | |||
There was a problem hiding this comment.
Can someone give both logFilePrefix and LogFileName ?
There was a problem hiding this comment.
We will throw in logger initialize in such case
src/Microsoft.TestPlatform.Extensions.TrxLogger/ObjectModel/TestRun.cs
Outdated
Show resolved
Hide resolved
| { | ||
| this.trxFilePath = Path.Combine(this.testResultsDirPath, logFileNameValue); | ||
| var framework = this.parametersDictionary[DefaultLoggerParameterNames.TargetFramework] ?? string.Empty; | ||
| framework = NuGetFramework.Parse(framework).GetShortFolderName(); |
There was a problem hiding this comment.
can this cause invalid chars in file path?
…i/vstest into MultiTargetTrxIssue
|
@vagisha-nidhi @hvinett We will need this for the html logger as well, Can you guys sync up on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RFC: microsoft/vstest-docs#204
Adding LogFilePrefix parameter to specify trx name prefix.
When this parameter is specified as
dotnet test --logger:"trx;LogFilePrefix=results", the prefix will be appended with target framework and timestamp generating a unique trx file for every target.Example:
E:\TestResults\results_net451_2018_12-24_14-01-07-176.trxTimestamp is appended with milli seconds precision.
Related issue
#1603