Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data collector extensibility in Test Plugin Cache #1991

Merged
merged 2 commits into from Apr 18, 2019
Merged

Data collector extensibility in Test Plugin Cache #1991

merged 2 commits into from Apr 18, 2019

Conversation

vagisha-nidhi
Copy link
Contributor

Description

  1. Adding datacollector extensions in test plugin cache and sending these to test host.
  2. This enables the InProcDataCollectionExtensionManager to be able to find the datacollector in all datacollector extension paths if inproc datacollector codebase path is not an absolute path.

@cltshivash
Copy link
Contributor 

    internal IDictionary<string, IInProcDataCollector> InProcDataCollectors;

not related to your PR, but please fix this (private..?)

Refers to: src/Microsoft.TestPlatform.CrossPlatEngine/DataCollection/InProcDataCollectionExtensionManager.cs:27 in 215b527. [](commit_id = 215b527, deletion_comment = False)

cltshivash
cltshivash reviewed Apr 17, 2019
View reviewed changes
...icrosoft.TestPlatform.CrossPlatEngine/DataCollection/InProcDataCollectionExtensionManager.cs
/// <returns> Codebase </returns>
private string GetCodebase(string codeBase)
{
return Path.IsPathRooted(codeBase) ? codeBase : Path.Combine(this.defaultCodeBase, codeBase);
if (!Path.IsPathRooted(codeBase))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: you can flip the condition. if (path.ispathrooted(,....)) { return codebase }

mayankbansal018
mayankbansal018 approved these changes Apr 17, 2019
View reviewed changes
Copy link
Contributor

@mayankbansal018 mayankbansal018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@vagisha-nidhi vagisha-nidhi merged commit 9ddaf36 into microsoft:master Apr 18, 2019
@vagisha-nidhi vagisha-nidhi mentioned this pull request May 16, 2019
Merged
@vagisha-nidhi vagisha-nidhi mentioned this pull request Jun 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cltshivash cltshivash cltshivash left review comments

@mayankbansal018 mayankbansal018 mayankbansal018 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vagisha-nidhi @cltshivash @mayankbansal018