Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migration to electron 7 for insiders #84384

Closed
ghost opened this issue Nov 9, 2019 · 4 comments
Closed

migration to electron 7 for insiders #84384

ghost opened this issue Nov 9, 2019 · 4 comments
Assignees

Comments

@ghost
Copy link

ghost commented Nov 9, 2019

done.

"electron 7" in vscode. assuming its the preferred instead of beta releases of electron.

saw #83930, but there was no companion issue.

main benefit seems to be electron/electron#20789, in addition to usual updates.


regards ratatoeey

@ghost ghost changed the title migration to electron 7 migration to electron 7 for insiders Nov 9, 2019
@ghost
Copy link
Author

ghost commented Nov 9, 2019

i would test but multiple reasons just make me avoid it, even before I get to other issues.

  • the yarn requirement being one of them. its the only blocker.
    if you have to use different tools, try deno https://deno.land/ , it can simplify stuff except it also lags in dependencies.

also would it be easier to migrate to electron 8 as its not stable yet? and it also would save the time spent on migrating to electron 7 as its already stable.

please tag this as question.

regards ratatoeey

@ghost
Copy link
Author

ghost commented Nov 9, 2019

from https://github.com/microsoft/vscode/wiki/Native-Crash-Issues
can it be installed using scoop? that would be great.

regards ratatoeey

@ShubhamBelwal
Copy link

There is no companion issue for electron 7 upgrade, but there is a pull request: #83796

@deepak1556
Copy link
Contributor

This has been completed, electron 7 is in current stable release 1.43.x

@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants