Terminal link tooltip location is wrong under the DOM renderer

[Tyriar]

The underline also isn't appearing

[z3-io]

I also encountered this problem on Ubuntu 16.04, underline is not displayed on std input , and std output for Terminal. Hope can be fixed.

Version 1.24.1
Commit 24f6262
Date 2018-06-13T17:47:35.732Z
Shell 1.7.12
Renderer 58.0.3029.110
Node 7.9.0
Architecture x64

[agurod42]

Hi!

After some testing I found that the problem (regarding tooltip location) seems to be that, when Linkifier emits the LinkHoverEventTypes.TOOLTIP event, the offsetX and offsetY properties of the fired MouseEvent instance are zero:

I believe this is because the DOM element which fires the event is the span rendering the character instead of some element with the size of the entire terminal (like the .xterm-cursor-layer in the default renderer).

In order to solve it, I added pointer-events: none; to .xterm-rows and .xterm-rows span styles so the mousemove event don't target those objects and the .xterm-screen becomes the offsetX, offsetY provider.

@Tyriar, do you think it is a good solution? I can make a PR, if you want.

Edit: Those changes should be made on the vscode-xterm package (And maybe this issue should be there also?)

[agurod42]

Regarding the underline don't appearing I'm trying this solution https://github.com/agurodriguez/xterm.js/commit/be4142d79582765600229103cb7a1e1bc2ac9058, and it seems to work (I'm going to sleep right now, but tomorrow I'll make some testing).

Do you think it's a feasible solution?

[alexr00]

@agurodriguez , we probably don't want to handle the tooltip location in xterm.js since xterm.js should just be providing all the info it has in the mouse event without making specific assumptions about how that info will be used. I'll let @Tyriar comment on the underline 😊

[Tyriar]

@agurodriguez I made some comments on the underline in that commit https://github.com/agurodriguez/xterm.js/commit/be4142d79582765600229103cb7a1e1bc2ac9058, looks pretty close to what we're after. I created xtermjs/xterm.js#1704 to track this, a PR would be fantastic! You would also want to remove the line in xterm.d.ts that says link underlines are not supported.

[agurod42]

Underline don't appearing was fixed in xtermjs/xterm.js#1705

We should wait for xterm's 3.8.0 release in order to update vscode and close this issue, right?

[Tyriar]

@agurodriguez I've already pulled in your changes, we'll close this off when #59060 is merged.

[Tyriar]

Hmm, something is still a bit off, mousing over and pausing on the bottom few pixels will show the tooltip in the correct position but the pixels above will show the tooltip where it should be for the line above 🤔

[agurod42]

I still have no idea why this is happening but this is what I got so far:

Target of the mouseover event in the expected behavior scenario:

The span right below the span where I had the pointer

Target of the mouseover event in the unexpected behavior scenario:

The actual span where I had the pointer

[Tyriar]

PR out upstream which should fix this: xtermjs/xterm.js#1716

[Tyriar]

I can no longer reproduce.