Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push strings for standalone editor to Transifex. #48108

Closed
dbaeumer opened this issue Apr 18, 2018 · 4 comments
Closed

Push strings for standalone editor to Transifex. #48108

dbaeumer opened this issue Apr 18, 2018 · 4 comments
Assignees

Comments

@dbaeumer
Copy link
Member

See microsoft/monaco-editor#822

@dbaeumer dbaeumer self-assigned this Apr 18, 2018
@dbaeumer dbaeumer added this to the On Deck milestone Apr 18, 2018
@dbaeumer dbaeumer added the debt Code quality issues label Apr 18, 2018
@dbaeumer
Copy link
Member Author

Closing.

@dbaeumer dbaeumer removed this from the On Deck milestone Sep 10, 2018
@dbaeumer dbaeumer removed the debt Code quality issues label Sep 10, 2018
@joechung-msft
Copy link

joechung-msft commented Sep 25, 2018

Is this fixed? Why is this being closed?

Copying comments from microsoft/monaco-editor#822:

It looks like someone removed these localizations in this commit:
3af180691c ("Cleaned up unused translation files. Merged translations from Transifex.", 2017-04-26)

Then later someone else moved the code whose localizations were removed to src/vs/editor/standalone:
1171b53005 ("Move standalone editor specific code to vs/editor/standalone", 2017-06-19)

@dbaeumer
Copy link
Member Author

I closed this in favor of microsoft/monaco-editor#822. This is nothing we can address in the vscode repository since it would add knowledge to the vscode repository about the monaco-editor repository. The strings that need translation in the monaco editor and are not part of the VS Code push need to be pushed by the editor. I VS Code we would only have the option to push all or nothing which doesn't seem to be the right approach.

Sorry for not making this clear when closing.

@joechung-msft
Copy link

Ah, that makes sense. Thank you for the explanation.

@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants