Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the default of the run/debug button in the editor to run #212919

Closed
webreidi opened this issue May 16, 2024 · 10 comments
Closed

Change the default of the run/debug button in the editor to run #212919

webreidi opened this issue May 16, 2024 · 10 comments
Assignees

Comments

@webreidi
Copy link

Feedback we got from users during our diary study was that the default of the run/debug button in the editor should be Run, as you want to run your program more than you want to debug it. You only want the added weight of the debug session when you need breakpoints to figure out a problem, but you run regularly to check progress. The added click of having to select the arrow to then Run was an extra step that users weren't happy about.

@webreidi
Copy link
Author

@isidorn This is the run as default issue we talked about today.

@WardenGnaw
Copy link
Member

Is this issue asking to reorder the listing of this dialog?
image

@webreidi
Copy link
Author

@WardenGnaw yes, as well as the icon change to the Run icon. So, if you don't use the arrow, you run your project.

@roblourens
Copy link
Member

So this is from the extension, right?

@webreidi
Copy link
Author

@roblourens No, I spoke with the Java team and the Python team and they all agree that this should be the default for all languages, not just for certain extensions.

@WardenGnaw
Copy link
Member

@roblourens To clarify this ask.

Instead of having extensions that contribute debuggers to contribute an additonal contributes.menus.editor/title/run.
There should be something similar to the Run menu dropdown, where it will just execute the debugger associated with the file extension and provide both "Run without Debugging" and "Start Debugging" options for any file. The existing contributions will be appened after those.

Proposal:
image

vscode-java-debug: https://github.com/microsoft/vscode-java-debug/blob/main/package.json#L193-L204
vscode-python-debugger: https://github.com/microsoft/vscode-python-debugger/blob/main/package.json#L113-L125

@gregg-miskelly
Copy link
Member

Suggestion: I think we should fix this in C# Dev Kit instead of trying to fix this centrally. A central fix is far trickier.

@isidorn
Copy link
Contributor

isidorn commented May 17, 2024

@WardenGnaw @webreidi can you help me understand this better.
So right now you can contribute commands to contributes.menus.editor/title/run. You can control the order - so that Run is first and is the default.

What is exactly missing? Why do you want a general Run, Debug buttons there? If I understand last comment from @WardenGnaw

@WardenGnaw
Copy link
Member

@isidorn I believe this was a discussion you had with @webreidi to centralize this?

@isidorn
Copy link
Contributor

isidorn commented May 17, 2024

@WardenGnaw
My understanding was that the main C# user problem is that Run is not the default option in the Editor title area.
I wrongly assumed that extension authors can not control the order of the actions there. But I was wrong, so I would suggest that for now C# DevKit just controls the order of contributed actions, and makes sure Run is first and the default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants