New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
screen reader issue since 1.89.0 with open file CTRL+p #211976
Comments
Looking at NVDA's log, I see this:
So we do announce the name, but the second you type another character that gets lost. In 1.88 it would re-say the file. |
The change that caused this regression is here: cc @joaomoreno and locally, in main, I reverted that commit and the issue went away. It looks like we were depending on that insert in order to trigger the a11y event to read things out. Repro:
Here's the Quick Pick tree accessibility provider, if it helps: vscode/src/vs/platform/quickinput/browser/quickInputTree.ts Lines 284 to 314 in 6373d80
And where we
I'm surprised by this behavior, esp since we don't use an identity provider anymore. |
The tree seems to be doing the right thing for performance sake: it is not modifying the DOM. Before #208913, the list row was thrown away and rendered again for no good reason. That had the nice side effect of A11Y being read as we desired. Trying to find a way to kick NVDA to still read it, even though nothing has changed. |
* quick pick: a11y workaround fixes #211976 * fix tests
Does this issue occur when all extensions are disabled?: Yes/No
Yes
Steps to Reproduce:
I'm using NVDA as screen reader, before 1.89.0 this worked:
CTRL+p
To be clear, image we have the following file/directory tree
|- dir1/
|--- abc.go
|- main.go
Doing CTRL+p and than typing
dir1/
it displayed theabc.go
file but screen reader says nothing.For result with multiple file, the first file of the list isn't "sent" to screen reader, doing down arrow and the second file in list is "said" by scree reader.
If I may this is a huge problem.
Thanks
The text was updated successfully, but these errors were encountered: