Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapped line commenting duplicates [+] button, hides button on hover, and the upper one doesn't work #211871

Open
ulugbekna opened this issue May 2, 2024 · 5 comments
Assignees
Labels
comments Comments Provider/Widget/Panel issues
Milestone

Comments

@ulugbekna
Copy link
Contributor

Description

Actual

When there's a diff chunk with a wrapped line:

  • there are 2 plus buttons (for adding a comment)
  • when hovering over line gutter, the buttons disappear
  • clicking on the upper button of the two buttons is a no-op
Screen.Recording.2024-05-03.at.00.12.24.mov

Expected

There is a single (vertically long?) plus button that doesn't disappear on hover.

Repro

  1. Have a diff chunk of a single line that's wrapped
@alexr00 alexr00 added bug Issue identified by VS Code Team member as probable bug comments Comments Provider/Widget/Panel issues labels May 3, 2024
@alexr00 alexr00 added this to the May 2024 milestone May 3, 2024
@alexr00
Copy link
Member

alexr00 commented May 3, 2024

  • there are 2 plus buttons (for adding a comment)

Duplicate of #156838

  • when hovering over line gutter, the buttons disappear
  • clicking on the upper button of the two buttons is a no-op

This I can't repro! I've tried zooming in and out to see if that causes it, but no luck. Can you share all your settings?

@alexr00 alexr00 removed this from the May 2024 milestone May 3, 2024
@alexr00 alexr00 added info-needed Issue requires more information from poster and removed bug Issue identified by VS Code Team member as probable bug labels May 3, 2024
@ulugbekna
Copy link
Contributor Author

ulugbekna commented May 3, 2024

when hovering over line gutter, the buttons disappear
clicking on the upper button of the two buttons is a no-op

Oh, it seems I can only repro on web - github.dev.

@alexr00
Copy link
Member

alexr00 commented May 7, 2024

Hmm. I still can't repro. What browser are you using?

@ulugbekna
Copy link
Contributor Author

I use chrome Version 124.0.6367.119 (Official Build) (arm64)

@VSCodeTriageBot
Copy link
Collaborator

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@VSCodeTriageBot VSCodeTriageBot closed this as not planned Won't fix, can't repro, duplicate, stale May 15, 2024
@alexr00 alexr00 reopened this May 15, 2024
@alexr00 alexr00 removed the info-needed Issue requires more information from poster label May 15, 2024
@alexr00 alexr00 added this to the May 2024 milestone May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comments Comments Provider/Widget/Panel issues
Projects
None yet
Development

No branches or pull requests

3 participants