Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal Icon picker weird placement #211083

Open
benibenj opened this issue Apr 23, 2024 · 4 comments · May be fixed by #211637, #211649 or #212174
Open

Terminal Icon picker weird placement #211083

benibenj opened this issue Apr 23, 2024 · 4 comments · May be fixed by #211637, #211649 or #212174
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities terminal-tabs
Milestone
Backlog

Comments

@benibenj
Copy link
Contributor

The terminal icon picker is positioned at the far top of the window. This looks a bit weird as the top border of the widget is not visible. I would have expected the widget to be placed bellow the command center.

image
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal-tabs labels Apr 24, 2024
@Tyriar Tyriar added this to the Backlog milestone Apr 24, 2024
@Tyriar Tyriar added help wanted Issues identified as good community contribution opportunities good first issue Issues identified as good for first-time contributors labels Apr 24, 2024
@Tyriar
Copy link
Member

Tyriar commented Apr 24, 2024

Code pointer:

vscode/src/vs/workbench/contrib/terminal/browser/terminalIconPicker.ts

Line 60 in 191a248

position: {

@Tyriar Tyriar mentioned this issue Apr 25, 2024
Closed
@sossost
Copy link

sossost commented Apr 28, 2024

hello! @Tyriar I'm sossost, a new contributor. I would like to solve this problem.

Which is the best solution
modifying the top border of the widget so that it is not cut off, or positioning the widget below the command center?

@Tyriar
Copy link
Member

Tyriar commented Apr 29, 2024

@sossost ideally we would position it below the command center when it's triggered via the command palette, or near the terminal tab if it's triggered from there.

@NanamiNakano NanamiNakano linked a pull request Apr 29, 2024 that will close this issue
Open
@sossost sossost linked a pull request Apr 29, 2024 that will close this issue
Open
@albarv340 albarv340 linked a pull request May 7, 2024 that will close this issue
Open
@tisilent
Copy link
Contributor

tisilent commented May 9, 2024

Wow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities terminal-tabs
Projects
None yet
Milestone
Backlog
4 participants
@Tyriar @benibenj @tisilent @sossost