Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test popular extensions with Electron 22 and custom memory allocator #177646

Closed
3 tasks done
bpasero opened this issue Mar 20, 2023 · 0 comments
Closed
3 tasks done

Test popular extensions with Electron 22 and custom memory allocator #177646

bpasero opened this issue Mar 20, 2023 · 0 comments
Assignees
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Mar 20, 2023

Refs: #177338

Complexity: 5

Create Issue


The new custom memory allocator in VS Code with Electron 22 should be tested to ensure:

  • our top extensions continue to work as before
  • extensions with known problematic native modules continue to work as before and do not crash VS Code

Prerequisites

Testing has to be done on (orange) VS Code exploration builds with Electron 22. Downloads:

Test Strategy

  • do exploratory smoke testing of the extension triggering some of its functionality to verify it works
  • see the native module the extension depends on to try to explicitly trigger the native code if possible
  • limit testing to 5 minutes max, since there are many extensions to test
  • watch out for extension host crashes or crashes in general

Test Top Extensions

With the exception of ms-toolsai.jupyter, none of the extensions below have known native modules that break the V8 memory cage, but nevertheless they are popular extensions we want to ensure work properly.

@bpasero bpasero added this to the March 2023 milestone Mar 20, 2023
@isidorn isidorn removed their assignment Mar 21, 2023
@deepak1556 deepak1556 removed their assignment Mar 22, 2023
@bpasero bpasero closed this as completed Mar 22, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants