Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal: Dotted looks more like dashed #158872

Closed
aeschli opened this issue Aug 23, 2022 · 2 comments
Closed

Terminal: Dotted looks more like dashed #158872

aeschli opened this issue Aug 23, 2022 · 2 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities terminal-rendering upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream
Milestone
December / Januar...

Comments

@aeschli
Copy link
Contributor

aeschli commented Aug 23, 2022

Testing #158827

Version: 1.71.0-insider
Commit: bd61073
Date: 2022-08-23T05:19:02.563Z
Electron: 19.0.12
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Darwin x64 21.6.0
Sandboxed: Yes

  • open a terminal and enter echo -e "\x1b[4:4m" # dotted underline

image

Note that it's not really dots, but lines of various length
@Tyriar Tyriar mentioned this issue Aug 23, 2022
Closed
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream terminal-rendering labels Aug 23, 2022
@Tyriar Tyriar added this to the Backlog milestone Aug 23, 2022
@Tyriar
Copy link
Member

Tyriar commented Aug 23, 2022

Upstream: xtermjs/xterm.js#4060

@meganrogge meganrogge removed their assignment Dec 5, 2022
@Tyriar
Copy link
Member

Tyriar commented Dec 13, 2023

This is fixed 🎉

@Tyriar Tyriar closed this as completed Dec 13, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities terminal-rendering upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream
Projects
None yet
Milestone
December / January 2024
Development

No branches or pull requests
4 participants
@Tyriar @aeschli @meganrogge @aiday-mar