Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't check for yarn.lock #744

Closed
hediet opened this issue Jun 21, 2022 · 1 comment · Fixed by #745
Closed

Don't check for yarn.lock #744

hediet opened this issue Jun 21, 2022 · 1 comment · Fixed by #745

Comments

@hediet
Copy link
Member

hediet commented Jun 21, 2022

Can we remove this check:

if (await exists(path.join(cwd, 'yarn.lock'))) {

And rely on yarn to throw error No lockfile in this directory. Run yarn install to generate one.?
This makes spotting mistakes easier. When using --yarn, the user very much expects the tool to be in a yarn working dir.

Also, this check doesn't work for yarn workspaces (though much other stuff also doesn't work for yarn workspaces, but they can be hacked around - this check cannot be hacked around).

@joaomoreno
Copy link
Member

Makes sense, wanna send over a PR?

@hediet hediet linked a pull request Jun 22, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants