Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support signed extensions #191

Open
vazexqi opened this issue Jul 11, 2017 · 8 comments
Open

Support signed extensions #191

vazexqi opened this issue Jul 11, 2017 · 8 comments
Assignees
Labels
feature-request Request for new features or functionality

Comments

@vazexqi
Copy link

vazexqi commented Jul 11, 2017

What is the story around signing VS Code extensions? I see that the vsce tool can package and publish .vsix files but there doesn't appear to be an option to sign them. I believe that .vsix files can be signed (https://docs.microsoft.com/en-us/visualstudio/extensibility/signing-vsix-packages).

What options do we have if we want to have stricter validation of the .vsix packages that we distribute and that our users install?

@vazexqi
Copy link
Author

vazexqi commented Jul 12, 2017

FWIW, it appears that I can use the VSIXSignTool and the .vsix is verified when I run vsixsigntool.exe \verify. The signed .vsix can be installed and runs in VS Code. However, when I install the the .vsix from VS Code there is neither indication or verification that the .vsix is signed.

@joaomoreno joaomoreno added this to the Backlog milestone Jul 12, 2017
@joaomoreno joaomoreno changed the title Any support for signed extensions? Support signed extensions Jul 12, 2017
@joaomoreno
Copy link
Member

No current support. It's a happy case that VS Code actually manages to installed a signed vsix. 👍

@vazexqi
Copy link
Author

vazexqi commented Jul 20, 2017

I'll monitor this issue. Let us know when you are working on it from the backlog and we will be happy to try it out.

For now, what we will do is provide a SHA256 of the .vsix on our product's page. That way, anyone can follow the steps at https://code.visualstudio.com/docs/editor/extension-gallery#_common-questions to manually download the .vsix and verify the checksums before installing them.

We have tried this with a small example and confirmed that the .vsix is not modified during upload, storage or download from the VS Code Marketplace.

vazexqi referenced this issue in forcedotcom/salesforcedx-vscode Jul 24, 2017
* Simplify command invocations are npm scripts
* Add shortcuts for running these commands from VS Code
* Use shx to run scripts in platform-agnostic manner
* Add scripts to help with packaging and publishing of .vsix
* Add instructions on how to publish
* Clarify how to run on Windows

@W-4162004@
@WinuxNomacs
Copy link

Sorely necessary. Visual Studio has had this for years now, including express. Lack of signature verification appears to be a significant oversight. Especially when Microsoft's own plugins (for example LiveShare) can't even be signed for their own editor. But then I guess they're fairly used to letting the world's computer population get pwned by malware and issuing a worthless "sorry, we f'd up again" ¯_(ツ)_/¯

@joaomoreno joaomoreno added feature-request Request for new features or functionality upstream labels Sep 20, 2018
@luispDesktop
Copy link

We were looking for VSCode to support signing validation as Visual Studio does as they both produce .vsix files.

@joaomoreno joaomoreno removed this from the Backlog milestone Oct 11, 2019
@tony--
Copy link

tony-- commented Feb 20, 2020

+1

@tr4nc3
Copy link

tr4nc3 commented Sep 4, 2020

Is this being planned anytime soon? This should be table steaks for a company like Microsoft that's a leader in security.

@yankunhuang-pku
Copy link

Excuse me, do we support this feature now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

7 participants