Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jedi causes "Do you want to terminate the active terminal session?" on close #23410

Open
wjandrea opened this issue May 10, 2024 · 2 comments
Open
Assignees
Labels
triage-needed Needs assignment to the proper sub-team

Comments

@wjandrea
Copy link

wjandrea commented May 10, 2024

Type: Bug

Behaviour

Popup on close: "Do you want to terminate the active terminal session?" even though none are running

Steps to reproduce:

  1. Set python.languageServer = Jedi (or Default if Pylance is not available)
  2. Make sure Jedi is running, for example, lint a Python script
  3. Try to exit VSC window

Diagnostic data

Output for Python in the Output panel (ViewOutput, change the drop-down the upper-right of the Output panel to Python)

2024-05-10 14:51:01.014 [info] Default formatter is set to ms-python.autopep8 for workspace /home/wja/testdir
2024-05-10 14:51:01.014 [info] Test server listening.
2024-05-10 14:51:01.014 [info] > conda info --json
2024-05-10 14:51:01.014 [info] Python interpreter path: ~/Programs/miniconda3/envs/anaconda3_11+/bin/python
2024-05-10 14:51:01.014 [info] > pyenv which python
2024-05-10 14:51:01.014 [info] cwd: .
2024-05-10 14:51:02.528 [info] > conda run -p ~/Programs/miniconda3/envs/anaconda3_11+ --no-capture-output python ~/.vscode-oss/extensions/ms-python.python-2024.4.1-universal/python_files/get_output_via_markers.py ~/.vscode-oss/extensions/ms-python.python-2024.4.1-universal/python_files/printEnvVariables.py
2024-05-10 14:51:02.529 [info] shell: bash
2024-05-10 14:51:02.911 [info] Starting Jedi language server for testdir.

I did an extension bisect to pin down the Python extension as causing the problem.

I'm using Codium and I'm not sure if this issue affects Code.

Extension version: 2024.4.1
VSCodium version: VSCodium 1.89.0 (4379b66f0d4dd9881ba96fa086f387725b69a24b, 2024-05-06T17:54:09.063Z)
OS version: Linux x64 5.4.0-181-generic
Modes:

@karthiknadig
Copy link
Member

We don't launch Jedi in a separate terminal. This has not been reported with VS Code, and also we have not made any changes to the Jedi launching code for a while now. So I am suspecting this might be an issue specific to VS Codium.

@karthiknadig karthiknadig self-assigned this May 13, 2024
@wjandrea
Copy link
Author

wjandrea commented May 13, 2024

@karthiknadig It very well could be. If you can't reproduce it on Code, LMK and I'll move this issue over there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage-needed Needs assignment to the proper sub-team
Projects
None yet
Development

No branches or pull requests

2 participants