Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to isort 5.5.3 #14027

Closed
hojo0590 opened this issue Sep 22, 2020 · 1 comment
Closed

Upgrade to isort 5.5.3 #14027

hojo0590 opened this issue Sep 22, 2020 · 1 comment
Assignees
@karrtikr
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@hojo0590
Copy link

hojo0590 commented Sep 22, 2020 •
edited

Environment data

  • Extension version (available under the Extensions sidebar): unreleased 2020.9

As of now 2020.9 #13924 is going to be released with isort 5.5.2 @karrtikr.
However there is a new version 5.5.3 with a bugfix PyCQA/isort#1488 for a bug that might mangle with a lot of vscode-python user's projects - isort might interfere with lines that are no imports.

Just as a warning...
@hojo0590 hojo0590 added triage-needed Needs assignment to the proper sub-team bug Issue identified by VS Code Team member as probable bug labels Sep 22, 2020
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Sep 22, 2020
@karrtikr karrtikr changed the title you're about to release with isort 5.5.2 while there is an important bugfix isort 5.5.3 Upgrade to isort 5.5.3 Sep 22, 2020
@karrtikr
Copy link

Thanks for the warning, we'll try to push it into next release!

@karrtikr karrtikr mentioned this issue Sep 22, 2020
Merged
@ghost ghost removed the needs PR label Sep 22, 2020
@karrtikr karrtikr mentioned this issue Sep 22, 2020
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@karrtikr karrtikr

Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@karthiknadig @karrtikr @hojo0590