Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data viewer contribution should handle multiple entrypoints #15680

Closed
pwang347 opened this issue May 9, 2024 · 4 comments · Fixed by #15681
Closed

Data viewer contribution should handle multiple entrypoints #15680

pwang347 opened this issue May 9, 2024 · 4 comments · Fixed by #15681
Assignees
Labels
data-viewer feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@pwang347
Copy link
Member

pwang347 commented May 9, 2024

Based on offline chat with @rebornix @amunger, it would be good for the Jupyter extension to support handling of other launch points such as the Debug panel and anywhere else the existing viewer is shown. Thanks!

@amunger
Copy link
Contributor

amunger commented May 10, 2024

currently blocked on Data Wrangler's jupyterVariableViewers command contribution needing to handle cases with a debug session and no notebook.

@amunger amunger added the verification-needed Verification of issue is requested label May 28, 2024
@amunger amunger added this to the May 2024 milestone May 28, 2024
@amunger
Copy link
Contributor

amunger commented May 28, 2024

verification steps:

  1. Install Python, DataWrangler and Jupyter pre-release extensions
  2. Create a .py file with the content below and set a breakpoint on the last print line
  3. Debug the file (not in the Interactive Window)
  4. When the breakpoint is hit, navigate to the variables view in the debug panel, right click df, and open the data viewer
  5. Ensure Data Wrangler's data viewer is opened
import pandas as pd

# create a dictionary with sample data
data = {
    "name": ["Alice", "Bob", "Charlie", "David"],
    "age": [25, 30, 35, 40],
    "gender": ["F", "M", "M", "M"],
}

df = pd.DataFrame(data)

# print the dataframe
print(df)

@rzhao271 rzhao271 added the verified Verification succeeded label May 28, 2024
@rzhao271
Copy link
Contributor

rzhao271 commented May 28, 2024

Does this count as the viewer opening for step 5? I'm in a venv with just pandas installed.

Data Wrangler opens to an error screen

@amunger
Copy link
Contributor

amunger commented May 28, 2024

it is being delegated correctly, we can just make that a new issue for DW

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data-viewer feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants