Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide quick fix for prettier suggestions #824

Closed
Timmmm opened this issue Dec 9, 2019 · 4 comments
Closed

Provide quick fix for prettier suggestions #824

Timmmm opened this issue Dec 9, 2019 · 4 comments
Labels
info-needed Issue requires more information from poster
Milestone

Comments

@Timmmm
Copy link

Timmmm commented Dec 9, 2019

You can run prettier through ESLint and it works very well, except it gives you quite hard to understand instructions. For example:

image

Normally I ignore these and fix them later via npm run lint which does some kind of magic to automatically fix them. However it would be better if it provided a quick fix to do it for you in VSCode.

I'm not sure if #806 would solve this - that task says it is for ambiguous fixes which this isn't.

@dbaeumer
Copy link
Member

@Timmmm this should be addressed with the new version since it will execute the same code path as eslint --fix.

Can you please test this as soon as I have released the new version which should happen the next couple of days.

@dbaeumer dbaeumer added the info-needed Issue requires more information from poster label Dec 10, 2019
@dbaeumer dbaeumer added this to the 2.0.0 milestone Dec 10, 2019
@Timmmm
Copy link
Author

Timmmm commented Dec 10, 2019

Excellent, will do!

@dbaeumer
Copy link
Member

Let me know how it goes.

@dbaeumer dbaeumer modified the milestones: 2.0.0, 2.0.5, 2.0.6 Dec 16, 2019
@dbaeumer
Copy link
Member

Dups #830

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

2 participants