Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: request to xxx failed, reason: certificate expired #3255

Closed
artcathcl opened this issue Oct 5, 2021 · 5 comments
Closed

Error: request to xxx failed, reason: certificate expired #3255

artcathcl opened this issue Oct 5, 2021 · 5 comments
Labels

Comments

@artcathcl
Copy link

artcathcl commented Oct 5, 2021

OS: Mac (will try windows)
Version: 1.17.0

Steps:

  1. add registry which uses Let's Encrypt certificate
  2. open docker vscode plugin, expand registry

Expect:
Should see list of images for that registry (rather than error message)

Actual:
See image below

Background:
We have a docker registry which uses Let's Encrypt certificate. We've recently (last few days) noticed an error reported by the VSCode Docker extension (when expanding Connected Registries for our server).

Error: request to xxx failed, reason: certificate expired

But ... the certificate is not expired :)

Operations (such as docker login) are working fine from command line.

Using Mac, by the way.

image

Interestingly, i just saw that POSTMAN fixed something that sounds very similar.
postmanlabs/postman-app-support#10338

@bwateratmsft
Copy link
Contributor

I saw something similar once when the system time was wrong. Is your clock and date right?

@artcathcl
Copy link
Author

artcathcl commented Oct 5, 2021

seems to be fine:

Tue Oct 5 16:12:38 EDT 2021

and happening for other people on my team.

@bwateratmsft
Copy link
Contributor

Wait, it's 2021?!

Just kidding 😄

I'll have to look into it further. We're ultimately just using Node's HTTP libraries, so I imagine this would affect anything in the extension host process trying to communicate with that site--not only the registry connection. It seems the Docker CLI is verifying the certificate in a different way and so isn't affected.

@bwateratmsft
Copy link
Contributor

Actually, I think maybe the fix will need to come from VSCode via Electron: electron/electron#31213, microsoft/vscode#134244

@artcathcl They mentioned that it's now fixed in Insiders, can you try VSCode Insiders and see if the issue is still there?

@artcathcl
Copy link
Author

woohoo :)

yes, that works. thanks for the tip!

@microsoft microsoft locked and limited conversation to collaborators Nov 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants