Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add progress or busy indication when extension is formatting. #56

Open
karthiknadig opened this issue May 21, 2022 · 2 comments
Open

Add progress or busy indication when extension is formatting. #56

karthiknadig opened this issue May 21, 2022 · 2 comments
Labels
feature-request Request for new features or functionality needs PR

Comments

@karthiknadig
Copy link
Member

Based on input from @Bobronium

This is definitely possible with the Progress APIs for LSP.
We just need to set workDoneProgress: True as the option when we register the Formatting feature @LSP_SERVER.feature
https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#documentFormattingOptions

Then in the params handle the progress token and respond accordingly to those params.
https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#clientInitiatedProgress

@github-actions github-actions bot added the triage-needed Issue is not triaged. label May 21, 2022
@karthiknadig karthiknadig added feature-request Request for new features or functionality needs PR and removed triage-needed Issue is not triaged. labels May 23, 2022
@agnes-sharan
Copy link

Hi is this issue still open for contribution?

@karthiknadig
Copy link
Member Author

@agnes-sharan Go ahead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality needs PR
Projects
None yet
Development

No branches or pull requests

2 participants